Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nightly FMT #319

Merged
merged 6 commits into from
Nov 8, 2023
Merged

Remove nightly FMT #319

merged 6 commits into from
Nov 8, 2023

Conversation

insipx
Copy link
Contributor

@insipx insipx commented Nov 8, 2023 •
edited
Loading

This removes all the nightly fmt features, so we will be formatting with default fmt on stable

closes #317

@insipx insipx marked this pull request as ready for review November 8, 2023 15:49
@insipx insipx requested a review from a team November 8, 2023 15:49
neekolas
neekolas approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@neekolas neekolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. I agree these formatting features are prettier. But nothing's more beautiful than a boring and reliable toolchain used for everything.

@jac18281828
Copy link
Contributor

I suggest updating the Dockerfile to remove the +nightly mentions

jac18281828
jac18281828 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@jac18281828 jac18281828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is working for me.

@insipx insipx merged commit 75f59d0 into main Nov 8, 2023
5 checks passed
@insipx insipx deleted the axe-nightly-fmt branch November 8, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jac18281828 jac18281828 jac18281828 approved these changes

@neekolas neekolas neekolas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove nightly fmt
3 participants
@insipx @jac18281828 @neekolas