Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key learnings:
sqlite3
command-line tool supportspragma key
, but encrypts/decrypts in a way that is non-compliant withsqlcipher
. There is asqlcipher
command-line tool that can be used to open sqlite databases encrypted viasqlcipher
instead.pragma key
initialization must be run on every connection, not just the first time the database is opened. If different connections write to the database with different encryption keys, the database becomes corrupted and can no longer be opened.Added fixes for these, as well as unit tests and updating READMEs.
Also modified the bindings to create an unencrypted database when no encryption key is passed, rather than an encrypted database with a hardcoded encryption key. This should make development/debugging a little bit easier. Note that there isn't much of a security difference between using a hardcoded encryption key and no encryption key at all.