Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update identity doc - ensure consistency of adds/removes #381

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

richardhuaaa
Copy link
Contributor

@richardhuaaa richardhuaaa commented Dec 14, 2023

Incorporating feedback from @neekolas, my summary of his ideas:

The most important thing about processing commits to add/remove members is consistency. When some members apply a commit and others reject it, the group state gets mangled.

The validation code must not rely on network requests to verify an added installation was not revoked - as this leaves open the door to race conditions where different group members get different results immediately after a revocation.

Let's allow revoked installations to be added, but group members should periodically check for revoked installations in the group, and publish a commit to remove them that all group members will apply consistently (this logic is already in the doc).

We should also be able to attach a revocation proof to remove commits so that members can validate removals without going to the network, in the same way that a credential is presented in add commits, so that members can validate adds without going to the network.

To shorten the time window after a revocation gets committed to every group, the installation performing the revocation should go ahead and update all the groups that it knows of (this logic is already in the doc).

xmtp_mls/IDENTITY.md Outdated Show resolved Hide resolved
Co-authored-by: Nicholas Molnar <[email protected]>
@richardhuaaa
Copy link
Contributor Author

FYI @karthikbhargavan

@richardhuaaa richardhuaaa enabled auto-merge (squash) December 14, 2023 23:31
@richardhuaaa richardhuaaa enabled auto-merge (squash) December 14, 2023 23:37
@richardhuaaa richardhuaaa merged commit 4262b13 into main Dec 14, 2023
7 checks passed
@richardhuaaa richardhuaaa deleted the rich/tweak-identity branch December 14, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants