-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streaming bindings #399
Merged
Merged
Streaming bindings #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplasterer
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍 I like the evolution of Intro, Invite, Welcome. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Message streaming requires the caller to implement a class in Swift/Kotlin that meets the
FfiMessageCallback
interface defined in the UDL file. Theon_message
function will be called once per message.Notes
I tried very hard to figure out a way to wrap a Stream type into something FFI friendly. The main issue is that our
group.stream()
method keeps a reference toself
for the life of the stream, which in turn has a lifetimed reference toClient
. This is required so that we can actually decrypt messages. The problem is that Uniffi doesn't play nicely with lifetimed references. We can't store aMlsGroup
on any sort of FFI friendly struct, and so the reference always gets dropped before the stream is done. This makes the compiler unhappy.Maybe someone smarter than me can figure it out (I've tried every permutation of boxes/arcs/mutexes I can think of), but I have to admit the callback interface might actually be easier in the end. At least we aren't exposing any sort of exotic types to Swift/Kotlin. The memory management should be simpler since the stream never leaves Rust-land.