interface for determining scw or eoa #615
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no fool-proof way to determine whether an address is a SCW or EOA. The best we have is to check the code-size on-chain. If the smart contract wallet has not yet been deployed, then there is no way of knowing just from the address whether an account is a SCW or an EOA.
This just adds a very simple trait,
WalletIdentity
for SDKs to implement in order to indicate whether an identity is a Smart Wallet or not.I couldn't decide whether this should live on
InboxOwner
or not. It seems to make sense for it to live on that trait, but I also didn't want to prematurely add a change intoxmtp_mls
that inbox's would have to implement w/o Identity being ready as a whole yet.I also found some unused dependencies, will have to look closer for those in reviews
closes #599