Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Association log verification #616

Closed
wants to merge 6 commits into from

Update from latest protos

16e0409
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Closed

Association log verification #616

Update from latest protos
16e0409
Select commit
Loading
Failed to load commit list.
GitHub Actions / workspace succeeded Apr 4, 2024 in 0s

workspace

11 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 11
Note 0
Help 0

Versions

  • rustc 1.77.1 (7cf61ebde 2024-03-27)
  • cargo 1.77.1 (e52e36006 2024-03-26)
  • clippy 0.1.77 (7cf61eb 2024-03-27)

Annotations

Check warning on line 64 in xmtp_id/src/associations/state.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

writing `&String` instead of `&str` involves a new object where a slice will do

warning: writing `&String` instead of `&str` involves a new object where a slice will do
  --> xmtp_id/src/associations/state.rs:64:49
   |
64 |     pub fn entities_by_parent(&self, parent_id: &String) -> Vec<Entity> {
   |                                                 ^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
   = note: `#[warn(clippy::ptr_arg)]` on by default
help: change this to
   |
64 ~     pub fn entities_by_parent(&self, parent_id: &str) -> Vec<Entity> {
65 |         self.current_entities
66 |             .values()
67 ~             .filter(|e| e.added_by_entity == Some(parent_id.to_owned()))
   |

Check warning on line 39 in xmtp_id/src/associations/state.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

you are using an explicit closure for cloning elements

warning: you are using an explicit closure for cloning elements
  --> xmtp_id/src/associations/state.rs:39:9
   |
39 |         self.current_entities.get(id).map(|e| e.clone())
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `self.current_entities.get(id).cloned()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
   = note: `#[warn(clippy::map_clone)]` on by default

Check warning on line 118 in xmtp_id/src/associations/association_log.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

this `if` statement can be collapsed

warning: this `if` statement can be collapsed
   --> xmtp_id/src/associations/association_log.rs:114:9
    |
114 | /         if self.new_member_signature.signature_kind() == SignatureKind::LegacyDelegated {
115 | |             if existing_state.xid != generate_xid(&existing_member_address, &0) {
116 | |                 return Err(AssociationError::LegacySignatureReuse);
117 | |             }
118 | |         }
    | |_________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
    = note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
    |
114 ~         if self.new_member_signature.signature_kind() == SignatureKind::LegacyDelegated && existing_state.xid != generate_xid(&existing_member_address, &0) {
115 +             return Err(AssociationError::LegacySignatureReuse);
116 +         }
    |

Check warning on line 89 in xmtp_mls/src/groups/subscriptions.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

redundant closure

warning: redundant closure
  --> xmtp_mls/src/groups/subscriptions.rs:89:13
   |
89 |             move |message| callback(message),
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `callback`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
   = note: `#[warn(clippy::redundant_closure)]` on by default

Check warning on line 43 in xmtp_mls/src/groups/members.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

unnecessary map of the identity function

warning: unnecessary map of the identity function
  --> xmtp_mls/src/groups/members.rs:42:22
   |
42 |                   .ok()
   |  ______________________^
43 | |                 .map(|basic_credential| (basic_credential))?;
   | |___________________________________________________________^ help: remove the call to `map`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity
   = note: `#[warn(clippy::map_identity)]` on by default

Check warning on line 59 in xmtp_api_grpc/src/auth_token.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

returning the result of a `let` binding from a block

warning: returning the result of a `let` binding from a block
  --> xmtp_api_grpc/src/auth_token.rs:59:9
   |
58 |         let token_base64 = base64::engine::general_purpose::STANDARD.encode(&token_bytes);
   |         ---------------------------------------------------------------------------------- unnecessary `let` binding
59 |         token_base64
   |         ^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
   = note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
   |
58 ~         
59 ~         base64::engine::general_purpose::STANDARD.encode(&token_bytes)
   |

Check warning on line 2424 in xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
    --> xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs:2424:91
     |
2424 |                     struct_ser.serialize_field("content", pbjson::private::base64::encode(&v).as_str())?;
     |                                                                                           ^^ help: change this to: `v`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 391 in xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs:391:115
    |
391 |                     struct_ser.serialize_field("unsignedLegacyCreateIdentityKey", pbjson::private::base64::encode(&v).as_str())?;
    |                                                                                                                   ^^ help: change this to: `v`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 387 in xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs:387:99
    |
387 |                     struct_ser.serialize_field("installationKey", pbjson::private::base64::encode(&v).as_str())?;
    |                                                                                                   ^^ help: change this to: `v`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 2951 in xmtp_proto/src/gen/xmtp.message_contents.serde.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
    --> xmtp_proto/src/gen/xmtp.message_contents.serde.rs:2951:86
     |
2951 |             struct_ser.serialize_field("senderHmac", pbjson::private::base64::encode(&v).as_str())?;
     |                                                                                      ^^ help: change this to: `v`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 1334 in xmtp_proto/src/gen/xmtp.message_contents.serde.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
    --> xmtp_proto/src/gen/xmtp.message_contents.serde.rs:1334:86
     |
1334 |                     struct_ser.serialize_field("v1", pbjson::private::base64::encode(&v).as_str())?;
     |                                                                                      ^^ help: change this to: `v`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
     = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default