Remove PartialEq from enum errors #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
37ng
force-pushed
the
04-09-remove_partialeq_from_errors
branch
2 times, most recently
from
26b2032 to
edb01c1
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
insipx
reviewed
Apr 10, 2024
37ng
force-pushed
the
04-09-remove_partialeq_from_errors
branch
from
edb01c1 to
efcddb4
Compare
insipx
approved these changes
Apr 10, 2024
neekolas
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Secondary errors will be required to implement
PartialEqbut it's not possible for external errors.If we want to compare errors, we can use different approach as showed.