Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message History 3/N #652

Merged
merged 13 commits into from
Apr 13, 2024
Merged

Message History 3/N #652

merged 13 commits into from
Apr 13, 2024
+113 −15

Conversation

tuddman
Copy link
Contributor

@tuddman tuddman commented Apr 11, 2024

Summary

  • Stubs out the request and response objects and first pass at fns that use them.
  • Includes the proto updates for supporting MessageHistoryRequest and MessageHistoryResponse
  • one function name change: add_idempotency_key() -> into_envelope(). to better reflect what the fn returns

@tuddman tuddman requested a review from a team as a code owner April 11, 2024 21:16
neekolas
neekolas approved these changes Apr 11, 2024
View reviewed changes
xmtp_mls/src/groups/mod.rs Outdated Show resolved Hide resolved
@tuddman
Copy link
Contributor Author

tuddman commented Apr 12, 2024

tests are failing; fix is in #654

@tuddman tuddman enabled auto-merge (squash) April 13, 2024 07:10
@tuddman tuddman merged commit 8cf15ef into main Apr 13, 2024
6 checks passed
@tuddman tuddman deleted the st/msg-hist-3 branch April 13, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neekolas neekolas neekolas approved these changes

Assignees
No one assigned
Labels
MLS DMs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuddman @neekolas @bwcDvorak