Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding pinned frame metadata field #888

Merged
merged 10 commits into from
Jul 3, 2024
Merged

Adding pinned frame metadata field #888

merged 10 commits into from
Jul 3, 2024

Conversation

cameronvoell
Copy link
Contributor

@cameronvoell cameronvoell commented Jul 2, 2024

Adds new metadata field GroupPinnedFrameUrl

@cameronvoell cameronvoell requested a review from a team as a code owner July 2, 2024 22:04
@@ -647,6 +651,7 @@ impl FfiCreateGroupOptions {
name: self.group_name,
image_url_square: self.group_image_url_square,
description: self.group_description,
pinned_frame: self.pinned_frame,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be pinned frame url to be more explicit it's a url?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably right I'll update that and fix these node bindings tests before merging 👌

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated 656c2c6

@cameronvoell cameronvoell merged commit 5c78fba into main Jul 3, 2024
6 checks passed
@cameronvoell cameronvoell deleted the cv/pinned-frame branch July 3, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants