-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding pinned frame metadata field #888
Conversation
c87f744
to
931a4f5
Compare
bindings_ffi/src/mls.rs
Outdated
@@ -647,6 +651,7 @@ impl FfiCreateGroupOptions { | |||
name: self.group_name, | |||
image_url_square: self.group_image_url_square, | |||
description: self.group_description, | |||
pinned_frame: self.pinned_frame, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be pinned frame url to be more explicit it's a url?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably right I'll update that and fix these node bindings tests before merging 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated 656c2c6
a2b3a5b
to
f94898d
Compare
Adds new metadata field
GroupPinnedFrameUrl