Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change stream methods to async fn in uniffi #912

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Change stream methods to async fn in uniffi #912

merged 2 commits into from
Jul 19, 2024

Conversation

insipx
Copy link
Contributor

@insipx insipx commented Jul 19, 2024 •
edited
Loading

Changing back to async fn should run the function within the defined tokio_runtime for uniffi

fix #910

@insipx insipx requested a review from a team as a code owner July 19, 2024 15:48
nplasterer
nplasterer approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@nplasterer nplasterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving if you validate this fixes it. 👍

@insipx insipx merged commit 5067440 into main Jul 19, 2024
9 checks passed
@insipx insipx deleted the insipx/fix-streaming-bug branch July 19, 2024 17:35
@nplasterer nplasterer mentioned this pull request Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nplasterer nplasterer nplasterer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Streaming all messages has a tokio error that crashes
2 participants
@insipx @nplasterer