Explicitly pass OpenMlsProvider to metadata functions #972
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow caller to decide whether to instantiate new connection or pass existing one. reduces the number of connections used for
list_members
.Note all of the metadata methods for a group pull their own
connection
. These methods are generally for one specific thing, and are the sorts of methods that may generally be composed with alot of the same call (iterate over$X
groups and get the group name for instance). if parallelized, these calls could possibly block the thread, since our SQLite pool is blocking. To mitigate this, we could 'reserve' a single SQLite connection, instantiate aXMTPOpenMlsProvider
with it, and re-use it for all read-only metadata methods. This will reduce the amount of concurrent connections being pulled from the pool.