Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest MLS #973

Merged
merged 10 commits into from
Aug 20, 2024
Merged

Use latest MLS #973

merged 10 commits into from
Aug 20, 2024

Conversation

neekolas
Copy link
Contributor

@neekolas neekolas commented Aug 19, 2024

tl;dr

  • Upgrades to the latest MLS which includes some bug fixes
  • Moves max_past_epochs values to the configuration.rs file
  • Checks is_valid_epoch in line with the MAX_PAST_EPOCHS configuration (now possible with the fixes in OpenMLS)
  • Simplifies testing for old epoch messages

@neekolas
Copy link
Contributor Author

neekolas commented Aug 19, 2024

I did some testing with the CLI, where I created a group using main and then switched over to this branch and added more members and sent messages. Everything seems to work as expected.

I'm less confident downgrading would succeed, but that isn't something we need to support.

@neekolas neekolas changed the title [WIP] Use latest MLS Use latest MLS Aug 19, 2024
@neekolas neekolas marked this pull request as ready for review August 19, 2024 23:29
@neekolas neekolas requested a review from a team as a code owner August 19, 2024 23:29
@neekolas neekolas merged commit 8eac6ab into main Aug 20, 2024
7 checks passed
@neekolas neekolas deleted the nm/latest-mls branch August 20, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants