Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to revoke installations #977

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Add ability to revoke installations #977

merged 2 commits into from
Aug 21, 2024

Conversation

neekolas
Copy link
Contributor

@neekolas neekolas commented Aug 21, 2024 •
edited
Loading

tl;dr

  • Exposes the ability to revoke installations
  • Updates the internal API for revoking wallets to not require the inbox_id. We can safely assume you're always doing this with your own inbox_id.
  • Adds a bunch more tests around revocation

@neekolas neekolas marked this pull request as ready for review August 21, 2024 15:44
@neekolas neekolas requested a review from a team as a code owner August 21, 2024 15:44
@neekolas neekolas requested a review from nplasterer August 21, 2024 16:47
@neekolas neekolas merged commit b54f94f into main Aug 21, 2024
6 checks passed
@neekolas neekolas deleted the nm/revocation-fixes branch August 21, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nplasterer nplasterer nplasterer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neekolas @nplasterer