Skip to content

Streaming bindings #249

Streaming bindings

Streaming bindings #249

GitHub Actions / workspace succeeded Jan 5, 2024 in 0s

workspace

3 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 3
Note 0
Help 0

Versions

  • rustc 1.75.0 (82e1608df 2023-12-21)
  • cargo 1.75.0 (1d8b05cdd 2023-11-20)
  • clippy 0.1.75 (82e1608 2023-12-21)

Annotations

Check warning on line 376 in xmtp_mls/src/client.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> xmtp_mls/src/client.rs:376:42
    |
376 |         Ok(MlsGroup::create_from_welcome(&self, &provider, welcome)
    |                                          ^^^^^ help: change this to: `self`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 377 in xmtp_mls/src/client.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

question mark operator is useless here

warning: question mark operator is useless here
   --> xmtp_mls/src/client.rs:376:9
    |
376 | /         Ok(MlsGroup::create_from_welcome(&self, &provider, welcome)
377 | |             .map_err(|e| ClientError::Generic(e.to_string()))?)
    | |_______________________________________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
    = note: `#[warn(clippy::needless_question_mark)]` on by default
help: try removing question mark and `Ok()`
    |
376 ~         MlsGroup::create_from_welcome(&self, &provider, welcome)
377 +             .map_err(|e| ClientError::Generic(e.to_string()))
    |

Check warning on line 1329 in xmtp_proto/src/gen/xmtp.message_contents.serde.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
    --> xmtp_proto/src/gen/xmtp.message_contents.serde.rs:1329:86
     |
1329 |                     struct_ser.serialize_field("v1", pbjson::private::base64::encode(&v).as_str())?;
     |                                                                                      ^^ help: change this to: `v`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
     = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default