Add Unsigned Identity Updates #875
workspace
9 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 9 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.77.1 (7cf61ebde 2024-03-27)
- cargo 1.77.1 (e52e36006 2024-03-26)
- clippy 0.1.77 (7cf61eb 2024-03-27)
Annotations
Check warning on line 75 in xmtp_id/src/associations/unsigned_actions.rs
github-actions / workspace
variants `CreateInbox`, `AddAssociation`, `RevokeAssociation`, and `ChangeRecoveryAddress` are never constructed
warning: variants `CreateInbox`, `AddAssociation`, `RevokeAssociation`, and `ChangeRecoveryAddress` are never constructed
--> xmtp_id/src/associations/unsigned_actions.rs:75:5
|
74 | pub enum UnsignedAction {
| -------------- variants in this enum
75 | CreateInbox(UnsignedCreateInbox),
| ^^^^^^^^^^^
76 | AddAssociation(UnsignedAddAssociation),
| ^^^^^^^^^^^^^^
77 | RevokeAssociation(UnsignedRevokeAssociation),
| ^^^^^^^^^^^^^^^^^
78 | ChangeRecoveryAddress(UnsignedChangeRecoveryAddress),
| ^^^^^^^^^^^^^^^^^^^^^
|
= note: `UnsignedAction` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
Check warning on line 89 in xmtp_mls/src/groups/subscriptions.rs
github-actions / workspace
redundant closure
warning: redundant closure
--> xmtp_mls/src/groups/subscriptions.rs:89:13
|
89 | move |message| callback(message),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `callback`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
Check warning on line 43 in xmtp_mls/src/groups/members.rs
github-actions / workspace
unnecessary map of the identity function
warning: unnecessary map of the identity function
--> xmtp_mls/src/groups/members.rs:42:22
|
42 | .ok()
| ______________________^
43 | | .map(|basic_credential| (basic_credential))?;
| |___________________________________________________________^ help: remove the call to `map`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity
= note: `#[warn(clippy::map_identity)]` on by default
Check warning on line 59 in xmtp_api_grpc/src/auth_token.rs
github-actions / workspace
returning the result of a `let` binding from a block
warning: returning the result of a `let` binding from a block
--> xmtp_api_grpc/src/auth_token.rs:59:9
|
58 | let token_base64 = base64::engine::general_purpose::STANDARD.encode(&token_bytes);
| ---------------------------------------------------------------------------------- unnecessary `let` binding
59 | token_base64
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
58 ~
59 ~ base64::engine::general_purpose::STANDARD.encode(&token_bytes)
|
Check warning on line 2424 in xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs
github-actions / workspace
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs:2424:91
|
2424 | struct_ser.serialize_field("content", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check warning on line 391 in xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs
github-actions / workspace
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs:391:115
|
391 | struct_ser.serialize_field("unsignedLegacyCreateIdentityKey", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check warning on line 387 in xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs
github-actions / workspace
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs:387:99
|
387 | struct_ser.serialize_field("installationKey", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check warning on line 2951 in xmtp_proto/src/gen/xmtp.message_contents.serde.rs
github-actions / workspace
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.message_contents.serde.rs:2951:86
|
2951 | struct_ser.serialize_field("senderHmac", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check warning on line 1334 in xmtp_proto/src/gen/xmtp.message_contents.serde.rs
github-actions / workspace
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.message_contents.serde.rs:1334:86
|
1334 | struct_ser.serialize_field("v1", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default