Skip to content

Merge branch '04-07-identityupdate_serialization' of github.com:xmtp/… #903

Merge branch '04-07-identityupdate_serialization' of github.com:xmtp/…

Merge branch '04-07-identityupdate_serialization' of github.com:xmtp/… #903

GitHub Actions / workspace succeeded Apr 7, 2024 in 0s

workspace

18 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 18
Note 0
Help 0

Versions

  • rustc 1.77.1 (7cf61ebde 2024-03-27)
  • cargo 1.77.1 (e52e36006 2024-03-26)
  • clippy 0.1.77 (7cf61eb 2024-03-27)

Annotations

Check warning on line 178 in xmtp_id/src/associations/serialization.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

unneeded `return` statement

warning: unneeded `return` statement
   --> xmtp_id/src/associations/serialization.rs:178:17
    |
178 |         None => return Err(DeserializationError::MissingSignature),
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
    |
178 |         None => Err(DeserializationError::MissingSignature),
    |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check warning on line 158 in xmtp_id/src/associations/serialization.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

unneeded `return` statement

warning: unneeded `return` statement
   --> xmtp_id/src/associations/serialization.rs:158:17
    |
158 |         None => return Err(DeserializationError::MissingMemberIdentifier),
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
    = note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
    |
158 |         None => Err(DeserializationError::MissingMemberIdentifier),
    |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check warning on line 110 in xmtp_id/src/associations/serialization.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

writing `&Vec` instead of `&[_]` involves a new object where a slice will do

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
   --> xmtp_id/src/associations/serialization.rs:110:14
    |
110 |     actions: &Vec<IdentityActionKindProto>,
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[IdentityActionKindProto]`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
    = note: `#[warn(clippy::ptr_arg)]` on by default

Check warning on line 35 in xmtp_id/src/associations/serialization.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

all variants have the same prefix: `Missing`

warning: all variants have the same prefix: `Missing`
  --> xmtp_id/src/associations/serialization.rs:28:1
   |
28 | / pub enum DeserializationError {
29 | |     #[error("Missing action")]
30 | |     MissingAction,
31 | |     #[error("Missing member identifier")]
...  |
34 | |     MissingSignature,
35 | | }
   | |_^
   |
   = help: remove the prefixes and use full paths to the variants instead of glob imports
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
   = note: `#[warn(clippy::enum_variant_names)]` on by default

Check warning on line 310 in xmtp_id/src/associations/builder.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> xmtp_id/src/associations/builder.rs:310:22
    |
310 |                 .get(&signer_identity)
    |                      ^^^^^^^^^^^^^^^^ help: change this to: `signer_identity`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 293 in xmtp_id/src/associations/builder.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> xmtp_id/src/associations/builder.rs:293:22
    |
293 |                 .get(&signer_identity)
    |                      ^^^^^^^^^^^^^^^^ help: change this to: `signer_identity`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 276 in xmtp_id/src/associations/builder.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> xmtp_id/src/associations/builder.rs:276:22
    |
276 |                 .get(&new_member_signer_identity)
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `new_member_signer_identity`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 271 in xmtp_id/src/associations/builder.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> xmtp_id/src/associations/builder.rs:271:22
    |
271 |                 .get(&existing_member_signer_identity)
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `existing_member_signer_identity`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 250 in xmtp_id/src/associations/builder.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> xmtp_id/src/associations/builder.rs:250:22
    |
250 |                 .get(&signer_identity)
    |                      ^^^^^^^^^^^^^^^^ help: change this to: `signer_identity`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 89 in xmtp_mls/src/groups/subscriptions.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

redundant closure

warning: redundant closure
  --> xmtp_mls/src/groups/subscriptions.rs:89:13
   |
89 |             move |message| callback(message),
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `callback`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
   = note: `#[warn(clippy::redundant_closure)]` on by default

Check warning on line 43 in xmtp_mls/src/groups/members.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

unnecessary map of the identity function

warning: unnecessary map of the identity function
  --> xmtp_mls/src/groups/members.rs:42:22
   |
42 |                   .ok()
   |  ______________________^
43 | |                 .map(|basic_credential| (basic_credential))?;
   | |___________________________________________________________^ help: remove the call to `map`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity
   = note: `#[warn(clippy::map_identity)]` on by default

Check warning on line 59 in xmtp_api_grpc/src/auth_token.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

returning the result of a `let` binding from a block

warning: returning the result of a `let` binding from a block
  --> xmtp_api_grpc/src/auth_token.rs:59:9
   |
58 |         let token_base64 = base64::engine::general_purpose::STANDARD.encode(&token_bytes);
   |         ---------------------------------------------------------------------------------- unnecessary `let` binding
59 |         token_base64
   |         ^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
   = note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
   |
58 ~         
59 ~         base64::engine::general_purpose::STANDARD.encode(&token_bytes)
   |

Check warning on line 2424 in xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
    --> xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs:2424:91
     |
2424 |                     struct_ser.serialize_field("content", pbjson::private::base64::encode(&v).as_str())?;
     |                                                                                           ^^ help: change this to: `v`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 391 in xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs:391:115
    |
391 |                     struct_ser.serialize_field("unsignedLegacyCreateIdentityKey", pbjson::private::base64::encode(&v).as_str())?;
    |                                                                                                                   ^^ help: change this to: `v`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 387 in xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs:387:99
    |
387 |                     struct_ser.serialize_field("installationKey", pbjson::private::base64::encode(&v).as_str())?;
    |                                                                                                   ^^ help: change this to: `v`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 2951 in xmtp_proto/src/gen/xmtp.message_contents.serde.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
    --> xmtp_proto/src/gen/xmtp.message_contents.serde.rs:2951:86
     |
2951 |             struct_ser.serialize_field("senderHmac", pbjson::private::base64::encode(&v).as_str())?;
     |                                                                                      ^^ help: change this to: `v`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 1334 in xmtp_proto/src/gen/xmtp.message_contents.serde.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
    --> xmtp_proto/src/gen/xmtp.message_contents.serde.rs:1334:86
     |
1334 |                     struct_ser.serialize_field("v1", pbjson::private::base64::encode(&v).as_str())?;
     |                                                                                      ^^ help: change this to: `v`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 916 in xmtp_proto/src/gen/xmtp.identity.associations.serde.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> xmtp_proto/src/gen/xmtp.identity.associations.serde.rs:916:105
    |
916 |                     struct_ser.serialize_field("installationPublicKey", pbjson::private::base64::encode(&v).as_str())?;
    |                                                                                                         ^^ help: change this to: `v`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default