fix: group id and installation id are bytes

xmtp · Jan 11, 2024 · e4cd0b5 · e4cd0b5
1 parent bf21f44
commit e4cd0b5
Show file tree

Hide file tree

Showing 6 changed files with 30 additions and 30 deletions.
diff --git a/go/mls/api/v1/mls.pb.go b/go/mls/api/v1/mls.pb.go
diff --git a/go/mls/message_contents/message.pb.go b/go/mls/message_contents/message.pb.go
diff --git a/go/mls_validation/v1/service.pb.go b/go/mls_validation/v1/service.pb.go
diff --git a/proto/mls/api/v1/mls.proto b/proto/mls/api/v1/mls.proto
@@ -239,7 +239,7 @@ message PagingInfo {
 
 // Request for group message queries
 message QueryGroupMessagesRequest {
-  string group_id = 1;
+  bytes group_id = 1;
   PagingInfo paging_info = 2;
 }
 
@@ -251,7 +251,7 @@ message QueryGroupMessagesResponse {
 
 // Request for welcome message queries
 message QueryWelcomeMessagesRequest {
-  string installation_id = 1;
+  bytes installation_id = 1;
   PagingInfo paging_info = 2;
 }
 
@@ -263,10 +263,10 @@ message QueryWelcomeMessagesResponse {
 
 // Request for following group messages
 message SubscribeGroupMessagesRequest {
-  string group_id = 1;
+  bytes group_id = 1;
 }
 
 // Request for following welcome messages
 message SubscribeWelcomeMessagesRequest {
-  string installation_id = 1;
+  bytes installation_id = 1;
 }
diff --git a/proto/mls/message_contents/message.proto b/proto/mls/message_contents/message.proto
@@ -26,7 +26,7 @@ message GroupMessage {
   message V1 {
     uint64 id = 1;
     uint64 created_ns = 2;
-    string group_id = 3;
+    bytes group_id = 3;
     bytes data = 4;
   }
 

diff --git a/proto/mls_validation/v1/service.proto b/proto/mls_validation/v1/service.proto
@@ -54,7 +54,7 @@ message ValidateGroupMessagesResponse {
   message ValidationResponse {
     bool is_ok = 1;
     string error_message = 2;
-    string group_id = 3;
+    bytes group_id = 3;
   }
 
   repeated ValidationResponse responses = 1;