wallet_address -> account_address #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neekolas
reviewed
Dec 19, 2023
| @@ -154,7 +154,7 @@ message RevokeInstallationRequest { | |||
|
|
|||
| // Get all updates for an identity since the specified time | |||
| message GetIdentityUpdatesRequest { | |||
| repeated string wallet_addresses = 1; | |||
| repeated string account_addresses = 1; | |||
There was a problem hiding this comment.
This one is going to require a corresponding change in xmtp-node-go
neekolas
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
The ones in the "did not update" column feel like something we can leave. Don't know if it's worth the trouble to manage a breaking change there.
If we did care, the move would be to add a second field and fill both. Then, later, we remove the first and mark the field number as "reserved".
|
Yep, I agree it's not worth the trouble - if we're ever overhauling these in the future, we can bundle it in then |
richardhuaaa
added a commit
to xmtp/libxmtp
that referenced
this pull request
Dec 19, 2023
Settling on consistent terminology as discussed. Depends on proto update xmtp/proto#121 Note that this will break any existing DB's - my upcoming credential update will also break existing DB's.
|
🎉 This PR is included in version 3.36.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did not update:
private_preferences.protokeystore.protoI assume that changes to these would break existing applications