-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HMAC Push notification updates #283
Conversation
@nplasterer I am currently looking into the build for test failures. From what I can see in the logs, the pipeline never gets to the test stage. I will update once I figure out the source. Going to switch to local builds to isolate it for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nplasterer Something is off with the protobuf code generation in service.connect.swift
that is causing build errors. Additionally, build for test fails as well, but I can't resolve those until the protobuf issue is corrected. See review comments inline for further details and LMK how I can help. 👨🏼🚒
Also update connect-swift package version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes by @kele-leanes to update the connect-swift
package addressed the protobuf questions. Additionally, some rearrangement of the if/def fencing in XMTPPush.swift
fixed the typealias
visibility when building for test in CI.
I was hoping to have more time to validate this this week but going to merge in favor unblocking integrators and will follow up with any tweaks once I've fully validated on Android. |
Adding the new HMAC code to the example and push classes to help make this easier.
See typescript docs here: https://github.com/xmtp/example-notification-server-go/blob/main/docs/notifications-client-guide.md