fix: ensure slashes aren't part of topics

xmtp · Nov 30, 2023 · b4836df · b4836df
1 parent 01757fb
commit b4836df
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Invitation.ts b/src/Invitation.ts
@@ -47,7 +47,7 @@ export class InvitationV1 implements invitation.InvitationV1 {
         .replace(/=*$/g, '')
         // Replace slashes with dashes so that the topic is still easily split by /
         // We do not treat this as needing to be valid Base64 anywhere
-        .replace('/', '-')
+        .replace(/\//g, '-')
     )
     const keyMaterial = crypto.getRandomValues(new Uint8Array(32))
 

diff --git a/test/utils/topic.test.ts b/test/utils/topic.test.ts
@@ -36,7 +36,7 @@ describe('topic utils', () => {
             .replace(/=*$/g, '')
             // Replace slashes with dashes so that the topic is still easily split by /
             // We do not treat this as needing to be valid Base64 anywhere
-            .replace('/', '-')
+            .replace(/\//g, '-')
         )
       )