Fix Node SDK lint issues

xmtp · Oct 16, 2024 · be3205a · be3205a
1 parent 325d9ca
commit be3205a
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 8 deletions.
diff --git a/sdks/node-sdk/src/Client.ts b/sdks/node-sdk/src/Client.ts
@@ -62,7 +62,7 @@ export type ContentOptions = {
   /**
    * Allow configuring codecs for additional content types
    */
-  codecs?: ContentCodec<any>[];
+  codecs?: ContentCodec[];
 };
 
 export type OtherOptions = {
@@ -84,9 +84,9 @@ export type ClientOptions = NetworkOptions &
 export class Client {
   #innerClient: NapiClient;
   #conversations: Conversations;
-  #codecs: Map<string, ContentCodec<any>>;
+  #codecs: Map<string, ContentCodec>;
 
-  constructor(client: NapiClient, codecs: ContentCodec<any>[]) {
+  constructor(client: NapiClient, codecs: ContentCodec[]) {
     this.#innerClient = client;
     this.#conversations = new Conversations(this, client.conversations());
     this.#codecs = new Map(
@@ -139,7 +139,7 @@ export class Client {
     try {
       const signatureText = await this.#innerClient.createInboxSignatureText();
       return signatureText;
-    } catch (e) {
+    } catch {
       return null;
     }
   }
@@ -149,7 +149,7 @@ export class Client {
   }
 
   addSignature(signatureBytes: Uint8Array) {
-    this.#innerClient.addSignature(
+    void this.#innerClient.addSignature(
       NapiSignatureRequestType.CreateInbox,
       signatureBytes,
     );
@@ -194,6 +194,7 @@ export class Client {
       throw new Error("Error decoding group membership change");
     }
 
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-return
     return codec.decode(message.content as EncodedContent, this);
   }
 

diff --git a/sdks/node-sdk/src/Conversation.ts b/sdks/node-sdk/src/Conversation.ts
@@ -166,7 +166,8 @@ export class Conversation {
     const encodedContent =
       typeof content === "string"
         ? this.#client.encodeContent(content, contentType ?? ContentTypeText)
-        : this.#client.encodeContent(content, contentType!);
+        : // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+          this.#client.encodeContent(content, contentType!);
 
     return this.#group.sendOptimistic(encodedContent);
   }
@@ -181,7 +182,8 @@ export class Conversation {
     const encodedContent =
       typeof content === "string"
         ? this.#client.encodeContent(content, contentType ?? ContentTypeText)
-        : this.#client.encodeContent(content, contentType!);
+        : // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+          this.#client.encodeContent(content, contentType!);
 
     return this.#group.send(encodedContent);
   }

diff --git a/sdks/node-sdk/src/DecodedMessage.ts b/sdks/node-sdk/src/DecodedMessage.ts
@@ -56,10 +56,12 @@ export class DecodedMessage {
       // no default
     }
 
+    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
     this.contentType = new ContentTypeId(message.content.type!);
     this.parameters = message.content.parameters;
     this.fallback = message.content.fallback;
     this.compression = message.content.compression;
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
     this.content = this.#client.decodeContent(message, this.contentType);
   }
 }
diff --git a/sdks/node-sdk/test/Client.test.ts b/sdks/node-sdk/test/Client.test.ts
@@ -11,7 +11,7 @@ describe("Client", () => {
     const client = await createClient(user);
     expect(client.accountAddress).toBe(user.account.address);
     expect(client.isRegistered).toBe(false);
-    expect(client.signatureText).not.toBe(null);
+    expect(await client.signatureText()).not.toBe(null);
     expect(client.inboxId).toBeDefined();
     expect(client.installationId).toBeDefined();
   });

diff --git a/sdks/node-sdk/test/helpers.ts b/sdks/node-sdk/test/helpers.ts
@@ -87,6 +87,7 @@ export class TestCodec implements ContentCodec<Record<string, string>> {
 
   decode(content: EncodedContent) {
     const decoded = new TextDecoder().decode(content.content);
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-return
     return JSON.parse(decoded);
   }