Use JobRunner to load consent list #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neekolas
approved these changes
Nov 15, 2023
Deploying with
|
| Latest commit: |
92e042e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2d344c7c.xmtp-js.pages.dev |
| Branch Preview URL: | https://rygine-pppp-update3.xmtp-js.pages.dev |
|
🎉 This PR is included in version 11.3.0-beta.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 11.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in this PR:
@xmtp/prototo support newJobRunnertypepppptype toJobRunnerresetLastRunTimemethod toJobRunner(see note below)JobRunnerwith option to disable itconversations.list()as it's now included with theJobRunnerresetmethod toConsentListfor clearing the current liststartTimewasundefinedJobRunnerfor loading the consent listlastSyncedAt=>lastConsentListEntryTimestampresetLastRunTime
the
Persistenceinterface doesn't supportremoveItemas it's not supported in every persistence layer and would require additional work to support in others. also, thesetItemmethod doesn't accept nil values. in order to support a "reset" of the last run time, this new method simply sets it to the epoch date.