Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bindings #795

Merged
merged 4 commits into from
Jan 21, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update node SDK tests
rygine committed Jan 21, 2025
commit da2f5e4a88c7062613190a0630a3fe13f1f5f2f4
2 changes: 2 additions & 0 deletions sdks/node-sdk/test/Conversation.test.ts
Original file line number Diff line number Diff line change
@@ -451,6 +451,7 @@ describe.concurrent("Conversation", () => {
updateGroupDescriptionPolicy: 0,
updateGroupImageUrlSquarePolicy: 0,
updateGroupPinnedFrameUrlPolicy: 0,
updateMessageExpirationMsPolicy: 2,
});

await conversation.updatePermission(
@@ -506,6 +507,7 @@ describe.concurrent("Conversation", () => {
updateGroupDescriptionPolicy: 2,
updateGroupImageUrlSquarePolicy: 2,
updateGroupPinnedFrameUrlPolicy: 2,
updateMessageExpirationMsPolicy: 2,
});
});
});
30 changes: 29 additions & 1 deletion sdks/node-sdk/test/Conversations.test.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { ConsentState, GroupPermissionsOptions } from "@xmtp/node-bindings";
import { v4 } from "uuid";
import { describe, expect, it } from "vitest";
import { createRegisteredClient, createUser } from "@test/helpers";

@@ -30,7 +31,7 @@ describe.concurrent("Conversations", () => {
expect(conversation.isActive).toBe(true);
expect(conversation.name).toBe("");
expect(conversation.permissions.policyType).toBe(
GroupPermissionsOptions.AllMembers,
GroupPermissionsOptions.Default,
);
expect(conversation.permissions.policySet).toEqual({
addMemberPolicy: 0,
@@ -41,6 +42,7 @@ describe.concurrent("Conversations", () => {
updateGroupDescriptionPolicy: 0,
updateGroupImageUrlSquarePolicy: 0,
updateGroupPinnedFrameUrlPolicy: 0,
updateMessageExpirationMsPolicy: 2,
});
expect(conversation.addedByInboxId).toBe(client1.inboxId);
expect((await conversation.messages()).length).toBe(1);
@@ -95,6 +97,7 @@ describe.concurrent("Conversations", () => {
updateGroupImageUrlSquarePolicy: 0,
updateGroupNamePolicy: 0,
updateGroupPinnedFrameUrlPolicy: 0,
updateMessageExpirationMsPolicy: 0,
});
expect(group.addedByInboxId).toBe(client1.inboxId);
expect((await group.messages()).length).toBe(0);
@@ -228,6 +231,7 @@ describe.concurrent("Conversations", () => {
updateGroupDescriptionPolicy: 2,
updateGroupImageUrlSquarePolicy: 2,
updateGroupPinnedFrameUrlPolicy: 2,
updateMessageExpirationMsPolicy: 2,
});

const groupWithDescription = await client1.conversations.newGroup(
@@ -272,6 +276,7 @@ describe.concurrent("Conversations", () => {
updateGroupDescriptionPolicy: 1,
updateGroupImageUrlSquarePolicy: 1,
updateGroupPinnedFrameUrlPolicy: 1,
updateMessageExpirationMsPolicy: 2,
},
},
);
@@ -288,6 +293,7 @@ describe.concurrent("Conversations", () => {
updateGroupDescriptionPolicy: 1,
updateGroupImageUrlSquarePolicy: 1,
updateGroupPinnedFrameUrlPolicy: 1,
updateMessageExpirationMsPolicy: 2,
});
});

@@ -529,4 +535,26 @@ describe.concurrent("Conversations", () => {
}
}
});

it("should sync groups across installations", async () => {
const user = createUser();
const client = await createRegisteredClient(user);
user.uuid = v4();
const client2 = await createRegisteredClient(user);
const user2 = createUser();
await createRegisteredClient(user2);

const group = await client.conversations.newGroup([user2.account.address]);
await client2.conversations.sync();
const convos = client2.conversations.list();
expect(convos.length).toBe(1);
expect(convos[0].id).toBe(group.id);

const group2 = await client.conversations.newDm(user2.account.address);
await client2.conversations.sync();
const convos2 = client2.conversations.list();
expect(convos2.length).toBe(2);
expect(convos2[0].id).toBe(group.id);
expect(convos2[1].id).toBe(group2.id);
});
});