-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RU.md for /docs/guide/cpp-time/ #102
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Спасибо за проделанную работу! ❤️
Есть пара мелких замечаний:
Co-Authored-By: bgoncharov <[email protected]>
Co-Authored-By: bgoncharov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution ❤️
The headings nesting level has to be fixed (see below) and we’re ready to merge. If you also find a bit of time to translate C++ comments as well, that would be great (optional though).
|
||
void evaluate(Context ctx) { | ||
if (isInputDirty<input_SET>(ctx)) { | ||
// Get T-input value. Conventionally it should be expressed in seconds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments in C++ are part of the article content. I won’t block the PR because of untranslated comments, but nevertheless, it would be fine.
Co-Authored-By: bgoncharov <[email protected]>
Co-Authored-By: bgoncharov <[email protected]>
RU.md for xod-docs/docs/guide/cpp-time/