Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RU.md for /docs/guide/cpp-time/ #102

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

bgoncharov
Copy link

RU.md for xod-docs/docs/guide/cpp-time/

@bgoncharov bgoncharov changed the title RU.md for xod-docs/docs/guide/cpp-time/ RU.md for /docs/guide/cpp-time/ Dec 16, 2018
Copy link
Contributor

@evgenykochetkov evgenykochetkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Спасибо за проделанную работу! ❤️

Есть пара мелких замечаний:

docs/guide/cpp-time/RU.md Outdated Show resolved Hide resolved
docs/guide/cpp-time/RU.md Outdated Show resolved Hide resolved
docs/guide/cpp-time/RU.md Outdated Show resolved Hide resolved
docs/guide/cpp-time/RU.md Outdated Show resolved Hide resolved
docs/guide/cpp-time/RU.md Outdated Show resolved Hide resolved
docs/guide/cpp-time/RU.md Outdated Show resolved Hide resolved
docs/guide/cpp-time/RU.md Outdated Show resolved Hide resolved
docs/guide/cpp-time/RU.md Outdated Show resolved Hide resolved
docs/guide/cpp-time/RU.md Outdated Show resolved Hide resolved
Copy link
Contributor

@evgenykochetkov evgenykochetkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution ❤️

The headings nesting level has to be fixed (see below) and we’re ready to merge. If you also find a bit of time to translate C++ comments as well, that would be great (optional though).

docs/guide/cpp-time/RU.md Outdated Show resolved Hide resolved
docs/guide/cpp-time/RU.md Outdated Show resolved Hide resolved
docs/guide/cpp-time/RU.md Outdated Show resolved Hide resolved
docs/guide/cpp-time/RU.md Outdated Show resolved Hide resolved
docs/guide/cpp-time/RU.md Outdated Show resolved Hide resolved
docs/guide/cpp-time/RU.md Outdated Show resolved Hide resolved
docs/guide/cpp-time/RU.md Outdated Show resolved Hide resolved

void evaluate(Context ctx) {
if (isInputDirty<input_SET>(ctx)) {
// Get T-input value. Conventionally it should be expressed in seconds
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments in C++ are part of the article content. I won’t block the PR because of untranslated comments, but nevertheless, it would be fine.

nkrkv and others added 2 commits March 4, 2019 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants