-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #2055
base: master
Are you sure you want to change the base?
Update README.md #2055
Conversation
corrected some linguistic mistakes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I see some issues with it though. If you can fix them, it would be super-nice. Or, if you want, we can fix them on your behalf.
@@ -107,7 +107,7 @@ This program is distributed in the hope that it will be useful, but WITHOUT ANY | |||
|
|||
You should have received a copy of the GNU Affero General Public License along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
|
|||
As a special exception, the copyright holders give permission to link the code of portions of this program with the OpenSSL library under certain conditions as described in each individual source file and distribute linked combinations including the program with the OpenSSL library. You must comply with the GNU Affero General Public License in all respects for all of the code used other than as permitted herein. If you modify file(s) with this exception, you may extend this exception to your version of the file(s), but you are not obligated to do so. If you do not wish to do so, delete this exception statement from your version. If you delete this exception statement from all source files in the program, then also delete it in the license file. | |||
As a special exception, the copyright holders permission to link the code of portions of this program with the OpenSSL library under certain conditions as described in each individual source file and distribute linked combinations including the program with the OpenSSL library. You must comply with the GNU Affero General Public License in all respects for all of the code used other than as permitted herein. If you modify the file(s) with this exception, you may extend this exception to your version of the file(s), but you are not obligated to do so. If you do not wish to do so, delete this exception statement from your version. If you delete this exception statement from all source files in the program, then also delete it in the license file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a legal copy-paste. An excerpt from the official AGPL license text. I’d prefer not to touch this.
* `yarn start:electron` — starts desktop IDE | ||
* `yarn start:spectron-repl` — starts functional tests environment | ||
* `yarn storybook` — starts React components viewer for visual inspection | ||
* `yarn storybook` — starts to React components viewer for visual inspection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the
is more appropriate here.
* `yarn build: electron` — build desktop IDE only | ||
* `yarn build:cli` — build CLI tools only | ||
* `yarn dev:browser` — run dev-version of browser IDE on localhost | ||
* `yarn dist:electron` — build OS-specific distributive of desktop IDE | ||
* `yarn dev: browser` — run dev-version of browser IDE on localhost | ||
* `yarn dist: electron` — build OS-specific distributive of desktop IDE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having no space after the colons is Yarn specifics. Shouldn’t be changed.
@@ -29,21 +29,21 @@ yarn build | |||
To start the desktop IDE run: | |||
|
|||
```bash | |||
yarn start:electron | |||
yarn start: electron |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having no space after the colons is Yarn specifics. Shouldn’t be changed.
``` | ||
|
||
Alternatively, run browser-based IDE: | ||
|
||
```bash | ||
yarn dev:browser | ||
yarn dev: browser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having no space after the colons is Yarn specifics. Shouldn’t be changed.
corrected some linguistic mistakes