Add Xopt and Badger version into routine #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roussel-ryan
reviewed
Oct 4, 2024
|
I'm reviewing this now, @wenatuhs can you add more details to the PR description? |
| @@ -48,6 +48,10 @@ def test_routine_generation(qtbot): | |||
| assert routine.vocs.objectives == {"f": "MINIMIZE"} | |||
| assert routine.initial_points.empty | |||
|
|
|||
| # test if badger and xopt version are embedded | |||
There was a problem hiding this comment.
can we make this test stronger by comparing it to the current version? (same goes for the tests in test_db)
There was a problem hiding this comment.
ie. routine.badger_version == str(badger.__version__) and similar for xopt
There was a problem hiding this comment.
Sure! Unfortunately we cannot do the same for test_db because we didn't add version numbers there -- there are corresponding fields but the value would be None. We of course can add version numbers first in the test but then it doesn't make sense to verify the just-added version numbers
roussel-ryan
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
open docsbutton on env config panel to show the readme of the corresponding env