Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packaging updates #102

Merged
merged 11 commits into from
Oct 7, 2024
Merged

Packaging updates #102

merged 11 commits into from
Oct 7, 2024

Conversation

pluflou
Copy link
Collaborator

@pluflou pluflou commented Oct 4, 2024

No description provided.

@pluflou pluflou marked this pull request as ready for review October 4, 2024 20:18
@YektaY YektaY self-requested a review October 7, 2024 17:59
YektaY
YektaY approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@YektaY YektaY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, I only have one small question on some commented out lines in the toml file.

pyproject.toml Show resolved Hide resolved
@pluflou
Copy link
Collaborator Author

pluflou commented Oct 7, 2024

@YektaY I just removed the MANIFEST.in since setuptools_scm will tell setuptools to add all files tracked by git to the sdist, which replaces what we have in the file

@YektaY YektaY merged commit e5bdc94 into xopt-org:main Oct 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YektaY YektaY YektaY approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pluflou @YektaY