Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ruff linting #105

Merged
merged 12 commits into from
Oct 29, 2024
Merged

Add ruff linting #105

merged 12 commits into from
Oct 29, 2024

Conversation

pluflou
Copy link
Collaborator

@pluflou pluflou commented Oct 10, 2024 •
edited
Loading

This PR lints and formats the codebase using Ruff's defaults (for now).
Remaining to-dos:

  • Adjust linting/formatting workflow
  • Add contribution guidelines regarding pre-commit hooks
  • Optional clean up item: do we want absolute or relative paths for imports? (needs to be made consistent across modules)

@pluflou pluflou requested review from wenatuhs and YektaY October 10, 2024 03:13
@pluflou pluflou marked this pull request as ready for review October 10, 2024 22:46
@roussel-ryan
Copy link
Collaborator

@pluflou we should use absolute paths imo, is this an easy change to make throughout the package?

@roussel-ryan roussel-ryan merged commit 42b53fc into xopt-org:main Oct 29, 2024
6 checks passed
@pluflou pluflou mentioned this pull request Oct 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roussel-ryan roussel-ryan roussel-ryan approved these changes

@wenatuhs wenatuhs Awaiting requested review from wenatuhs

@YektaY YektaY Awaiting requested review from YektaY

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pluflou @roussel-ryan