ENH: Error message pop-up #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok, this is ready for review. I would definitely try it out and let me know if you want any other changes or features. |
|
Looks mostly good, but the detailed traceback is not being shown |
|
Ok, I have added the traceback of the exception or the call stack - it looks like a lot of the issues are raised outside of a try except block, so the popup occurs before the exception, so instead it displays the call stack in these cases. |
|
Yep that works, can we wrap the following code in a BadgerRuntime Error or similar such that the errorbox pops up |
…g to get a popup with the error
…ce it's a subprocess
roussel-ryan
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes a base BadgerError class and then adds a popup that contains a message for the user. It also changes the name of BadgerRunTerminatedError exception to BadgerRunTerminated