ENH: Creates a config.yaml file to hold badger's settings #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YektaY
commented
Jul 15, 2024
…on for validating and holding the configuaration data. a few bug remain and there are two more features needed for this feature to be complete
YektaY
changed the title
roussel-ryan
reviewed
Oct 4, 2024
|
Also need to resolve merge conflicts |
|
I removed the commented out code and fixed the merge conflict. let me know if there is anything else needed on this PR |
roussel-ryan
approved these changes
Oct 21, 2024
|
@wenatuhs this is ready to go if you don't have any changes needed on your side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR creates a config.yaml file to hold badger's settings. it also changed the internal plumbing of the settings. Changing from a design which used global variables paired with QSettings to a design which uses pydantic class which holds the default settings, a config file which badger loads in to replace the default settings and a singleton to hold the settings and pipe it throughout the rest of the application.
How Has This Been Tested?
Unit tests need to be added to make this PR ready for release
Where Has This Been Documented?
Auto documentation has been added to all new methods.
The process will be noted on the website
Screenshots: