-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Update pandas read_* funcions of dtype_backend
param with pyarrow
#843
ENH: Update pandas read_* funcions of dtype_backend
param with pyarrow
#843
Conversation
- Renamed 'use_arrow_dtype' to 'dtype_backend' in read_parquet and updated related logic to align with pandas and Dask. - Adjusted read_csv and read_sql files to ensure compatibility and reflect the new parameter where applicable. - Added relevant documentation updates to reflect these changes. This change aims at providing a consistent user experience across pandas, Dask, and xorbits by adopting the 'dtype_backend' parameter.
…naweiben/xorbits into feature/dtype-backend-update
Fix segmentation fault in tensor operations by adding version constraints for numpy and pyarrow in Python 3.11 test environment. The issue occurs in numpy.searchsorted when used with newer versions of numpy (>=2.2.0) and pyarrow (>=19.0.0) in tensor-related tests.
…to feature/dtype-backend-update
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (82.03%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #843 +/- ##
==========================================
- Coverage 82.04% 82.03% -0.01%
==========================================
Files 1071 1071
Lines 80153 80155 +2
Branches 12202 12203 +1
==========================================
+ Hits 65758 65759 +1
+ Misses 12837 12830 -7
- Partials 1558 1566 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use numpy
or numpy_nullable
for dtype_backend
.
…e `dtype_backend` parameter across the DataFrame-related functionalities in Xorbits.
- Change the parameter "use_arrow_dtype" to "dtype_backend" in the benchmark.
…to feature/dtype-backend-update
The optional values for the parameter |
dtype_backend
param of read_* with pyarrow engine
dtype_backend
param of read_* with pyarrow enginedtype_backend
param with pyarrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What do these changes do?
Update dtype_backend parameter for consistency with pandas
use_arrow_dtype
todtype_backend
in read_parquet and updated related logic to align with pandas and Dask.This change aims at providing a consistent user experience across pandas, Dask, and xorbits by adopting the
dtype_backend
parameter.Related issue number
Fixes #770
Check code requirements