BUG: Fix XGBoost/LightGBM test execution and scikit-learn compatibility #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Replace force_all_finite with ensure_all_finite to fix FutureWarning - Update validation.py, _data.py and test_validation.py - This change aligns with sklearn's future deprecation plan 2. Fix DataConversionWarning in LabelEncoder - Add ravel() preprocessing before column_or_1d - This ensures input data is in the correct 1D format 3. Fix ValueError in lightgbm classifier test - Add rechunk after boolean filtering - This ensures chunk sizes match the actual data size Fixes the following issues: - FutureWarning about force_all_finite deprecation - DataConversionWarning about column vector input - ValueError about mismatched chunk sizes
This fixes the F821 undefined name 'force_all_finite' lint error in validation.py. The parameter was already renamed to ensure_all_finite in other places, but was missed in the check_X_y function.
This fixes the black formatting issue in the CI.
- Remove strict requirement for identical keys in dictionaries - Add support for nested dictionaries and mixed value types - Handle list and non-list values intelligently - Fix XGBoost training history merging issue
Due to recent security updates in the HuggingFace datasets library, explicitly set trust_remote_code=True when loading datasets with custom code. This change ensures tests continue to work with newer versions of the datasets library while maintaining security best practices.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (82.06%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #846 +/- ##
==========================================
+ Coverage 82.04% 82.06% +0.02%
==========================================
Files 1071 1071
Lines 80155 80162 +7
Branches 12203 12206 +3
==========================================
+ Hits 65760 65783 +23
- Misses 12834 12837 +3
+ Partials 1561 1542 -19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
force_all_finitetoensure_all_finitefor scikit-learn API compatibilityRelated issue number
Fixes #xxxx
Check code requirements