CI: improve iteration over multiple changed files #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linkmauve
reviewed
Dec 6, 2024
| run: | | ||
| sudo apt-get install -y libxml2-utils | ||
| result=0 | ||
| for xep in "${{ steps.changed-xeps.outputs.all_changed_files }}"; do | ||
| for xep in ${ALL_CHANGED_FILES}; do |
There was a problem hiding this comment.
I believe you could make this change simpler just by removing the quotes here (untested):
Suggested change
| for xep in ${ALL_CHANGED_FILES}; do | |
| for xep in ${{ steps.changed-xeps.outputs.all_changed_files }}; do |
There was a problem hiding this comment.
... possibly, but I definitely tested the commit as-is, and I don't think the proposed modification makes things considerably more easy. I'm happy to go with the commit as-is, unless someone feels strongly about this and wants to test the alternative.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The quotation made the list of files be interpreted as one very long filename.
Split off in a environment variable to better match the examples provided by tj-actions/changed-files