special case empty separators in string split

y21 · Jan 17, 2024 · 9a585ca · 9a585ca
1 parent 6b0f915
commit 9a585ca
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/crates/dash_vm/src/js_std/string.rs b/crates/dash_vm/src/js_std/string.rs
@@ -276,10 +276,17 @@ pub fn split(cx: CallContext) -> Result<Value, Value> {
         .res(cx.scope)
         .to_owned();
 
-    let result = string
-        .split(&separator)
-        .map(|s| PropertyValue::static_default(Value::String(cx.scope.intern(s).into())))
-        .collect();
+    let result = if separator.is_empty() {
+        string
+            .chars()
+            .map(|c| PropertyValue::static_default(Value::String(cx.scope.intern_char(c).into())))
+            .collect()
+    } else {
+        string
+            .split(&separator)
+            .map(|s| PropertyValue::static_default(Value::String(cx.scope.intern(s).into())))
+            .collect()
+    };
 
     let array = Array::from_vec(cx.scope, result);
     Ok(cx.scope.register(array).into())