MaxAsyncAfterSeconds Default Value Assignment #1960
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moizarafat
requested review from
aklish and
rishi-aga
and removed request for
aklish
rishi-aga
previously approved these changes
Mar 25, 2021
aklish
requested changes
Mar 25, 2021
elide-async/src/main/java/com/yahoo/elide/async/hooks/AsyncAPIHook.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1949
Description
Fix for "Invalid Max Async After Seconds" error when the configured MaxAsyncAfterSeconds in application.yaml or standalone settings was less than 10.
Motivation and Context
Resolves incorrect error message
How Has This Been Tested?
Existing test case pass.
`
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.