Skip to content
This repository has been archived by the owner on Jan 4, 2021. It is now read-only.

Update peer_stores.py #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update peer_stores.py #6

wants to merge 1 commit into from

Conversation

tejt99
Copy link
Contributor

@tejt99 tejt99 commented Aug 3, 2019

Fixed errors generated by a module being renamed.

@@ -15,7 +15,7 @@

import socket
import random
from urlparse import urlparse
Copy link
Contributor Author

@tejt99 tejt99 Aug 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To Do:
Add cross-compatibility for py2 and py3

Edit:
No need

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take your viewpoint if you want to retain Python2 compatibility. It wouldn't be difficult, just need to do a try and look for an ImportError. urlparse in Python 2 and 3 seems similar enough to be all it should need. However, my preference would be to focus entirely on Python 3 as per expected Python 2.7 deprecation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@yamatt yamatt mentioned this pull request Aug 3, 2019
@yamatt yamatt added the on-hold Cannot be completed, yet label Aug 3, 2019
@yamatt
Copy link
Owner

yamatt commented Aug 3, 2019

On hold to deal with backwards compatibility query as per comment above.

@tejt99
Copy link
Contributor Author

tejt99 commented Aug 4, 2019

Sorry about that comment I have been looking at a large amount of gitHub repositories trying to find a torrent opener that works. There was one that was cross compatible and I thought it was this one, I will remove the comment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
on-hold Cannot be completed, yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants