Prevent React setState on unmounted Component #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent React setState on unmounted Component
piranna
reviewed
Mar 28, 2019
piranna
reviewed
Mar 28, 2019
| @@ -37,11 +39,13 @@ exports.InViewPort = class extends Component { | |||
| return | |||
| } | |||
| this.myview.measure((x, y, width, height, pageX, pageY) => { | |||
There was a problem hiding this comment.
Check also here that component is mounted before starting timeout (failsafe).
There was a problem hiding this comment.
Technically it is already failsafe "startWatching" is called only in "componentDidMount" and "componentWillReceiveProps" these lifecycle methods are invoked after the component are mounted
There was a problem hiding this comment.
Being public methods they can be called from outside...
piranna
approved these changes
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although there is a method "stopWatching" which is called in "componentWillUnmount" and clear the interval, is possible that the native method "measure" async callback is returned with the component already unmounted.