Updated for newest version of react native #5
+14
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we merge this? |
|
+1 |
|
This PR actually breaks with react-native 0.38. Importing ES6-style fixes it. |
chandlervdw
reviewed
Nov 30, 2016
| var React = require('react-native'); | ||
| var window = React.Dimensions.get('window'); | ||
| var {View, NativeMethodsMixin} = React; | ||
| var React = require('react'); |
There was a problem hiding this comment.
import React from 'react';
import { Dimensions, View, NativeMethodsMixin } from 'react-native';
const window = Dimensions.get('window');
|
Is their any chance this will be merged? This will probably help me figure out an issue with a listview inside a scrollview. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requiring React from 'react-native' no longer works in latest versions of react.
See https://github.com/facebook/react-native/releases/tag/v0.25.1