Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cron compatibility to unix standard - 5 tokens #3

Merged
merged 7 commits into from
Mar 24, 2024

Conversation

yamilmedina
Copy link
Owner

In this PR

Fix

  • Standard compliance by default with Unix 5 tokens.

Chore

  • Adds tests coverage for more cases.
  • Move packages around.

Copy link

github-actions bot commented Mar 24, 2024

Test Results

49 tests  +44   49 ✔️ +44   0s ⏱️ ±0s
  1 suites ±  0     0 💤 ±  0 
  1 files   ±  0     0 ±  0 

Results for commit a91a27b. ± Comparison against base commit 211b2c7.

This pull request removes 5 and adds 49 tests. Note that renamed tests count towards both.
io.github.yamilmedina.naturalkron.NaturalKronExpressionParserTest ‑ given a partial invalid expression, then parse valid part()
io.github.yamilmedina.naturalkron.NaturalKronExpressionParserTest ‑ given an invalid expression, then raise KronException()
io.github.yamilmedina.naturalkron.NaturalKronExpressionParserTest ‑ given every day at 9am is parsed, then returns every day expression with date()
io.github.yamilmedina.naturalkron.NaturalKronExpressionParserTest ‑ given every friday at 1015am is parsed, then returns every monday expression()
io.github.yamilmedina.naturalkron.NaturalKronExpressionParserTest ‑ given every monday is parsed, then returns every monday expression()
io.github.yamilmedina.kron.NaturalKronParserTest ‑ [10] CASE_10
io.github.yamilmedina.kron.NaturalKronParserTest ‑ [11] CASE_11
io.github.yamilmedina.kron.NaturalKronParserTest ‑ [12] CASE_12
io.github.yamilmedina.kron.NaturalKronParserTest ‑ [13] CASE_13
io.github.yamilmedina.kron.NaturalKronParserTest ‑ [14] CASE_14
io.github.yamilmedina.kron.NaturalKronParserTest ‑ [15] CASE_15
io.github.yamilmedina.kron.NaturalKronParserTest ‑ [16] CASE_16
io.github.yamilmedina.kron.NaturalKronParserTest ‑ [17] CASE_17
io.github.yamilmedina.kron.NaturalKronParserTest ‑ [18] CASE_18
io.github.yamilmedina.kron.NaturalKronParserTest ‑ [19] CASE_19
…

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@yamilmedina yamilmedina self-assigned this Mar 24, 2024
@yamilmedina yamilmedina merged commit c9c1a27 into main Mar 24, 2024
2 checks passed
@yamilmedina yamilmedina deleted the fix/cron-compat branch March 24, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants