Skip to content

Commit

Permalink
[rev.4]
Browse files Browse the repository at this point in the history
  • Loading branch information
aalexfvk committed Jan 25, 2024
1 parent daaec19 commit 12f352b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
5 changes: 4 additions & 1 deletion tests/features/object_storage.feature
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ Feature: chadmin object-storage commands
"""
Then S3 contains greater than 0 objects

@require_version_23.3
Scenario: Dry-run clean on one replica with guard period
When we execute command on clickhouse01
"""
Expand All @@ -36,7 +37,7 @@ Feature: chadmin object-storage commands
Would delete [1-9][0-9]* objects from bucket \[cloud-storage-test\]
"""


@require_version_23.3
Scenario: Dry-run clean on cluster with guard period
When we execute command on clickhouse01
"""
Expand All @@ -55,6 +56,7 @@ Feature: chadmin object-storage commands
Would delete 0 objects from bucket [cloud-storage-test]
"""

@require_version_23.3
Scenario: Clean orphaned objects
When we put object in S3
"""
Expand Down Expand Up @@ -84,6 +86,7 @@ Feature: chadmin object-storage commands
path: /data/orpaned_object.tsv
"""

@require_version_23.3
Scenario: Clean many orphaned objects
When we put 100 objects in S3
"""
Expand Down
2 changes: 1 addition & 1 deletion tests/steps/s3.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def step_s3_contains_greater_than_files(context, count):
@then("S3 bucket {bucket} contains {count:d} objects")
def step_cloud_storage_bucket_contains_files(context, bucket, count):
s3_client = s3.S3Client(context, bucket)
objects = s3_client.list_objects("/")
objects = s3_client.list_objects("")
assert_that(
len(objects),
equal_to(count),
Expand Down

0 comments on commit 12f352b

Please sign in to comment.