Fix ext-ip-dns check without IPv6

yandex · Oct 16, 2023 · 3502459 · 3502459
1 parent f13de94
commit 3502459
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/ch_tools/monrun_checks/ext_ip_dns.py b/ch_tools/monrun_checks/ext_ip_dns.py
@@ -75,11 +75,12 @@ def _compare(record_type: str, ip_type: str) -> Tuple[bool, set, set]:
         err.append(
             f"{target.fqdn}: invalid A: expected {target_addr}, actual {actual_addr}"
         )
-    ok, target_addr, actual_addr = _compare("AAAA", "ipv6")
-    if ipv6 and not ok:
-        err.append(
-            f"{target.fqdn}: invalid AAAA: expected {target_addr}, actual {actual_addr}"
-        )
+    if ipv6:
+        ok, target_addr, actual_addr = _compare("AAAA", "ipv6")
+        if not ok:
+            err.append(
+                f"{target.fqdn}: invalid AAAA: expected {target_addr}, actual {actual_addr}"
+            )
 
     return err