Add total size counting for object-storage clean command
#104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalexfvk
changed the title
object-storage clean command
| f"{'Would delete' if dry_run else 'Deleted'} {deleted} objects from bucket [{disk_conf.bucket_name}] with prefix {prefix}" | ||
| # Generator producing keys from temporary file with counting of statistics | ||
| def keys(): | ||
| nonlocal deleted, total_size |
There was a problem hiding this comment.
As for me it is non trivial logic.
Can we count total size and the number of deleted objects inside cleanup_s3_object_storage and use return value for some statistic that we have collected? Also we already have logic to count the number of deleted objects:
ch-tools/ch_tools/chadmin/internal/object_storage/s3_cleanup.py
Lines 25 to 28 in deeefdf
There was a problem hiding this comment.
I agree, partially. I thought to do that, but then decided not to count size statistics in cleanup function. But now I'll do that
MikhailBurdukov
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add counting of total size of all orphaned objects for
object-storage cleancommand.Support standard output formats: table, yaml, json.