Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote database and table names in SYSTEM SYNC REPLICA query #110

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

Alex-Burmak
Copy link
Member

Fix for the following error:

            Traceback (most recent call last):
              File "/usr/bin/chadmin", line 8, in <module>
                sys.exit(main())
              File "/opt/yandex/clickhouse-tools/lib/python3.6/site-packages/ch_tools/chadmin/chadmin_cli.py", line 159, in main
                cli.main()
              File "/opt/yandex/clickhouse-tools/lib/python3.6/site-packages/click/core.py", line 1053, in main
                rv = self.invoke(ctx)
              File "/opt/yandex/clickhouse-tools/lib/python3.6/site-packages/click/core.py", line 1659, in invoke
                return _process_result(sub_ctx.command.invoke(sub_ctx))
              File "/opt/yandex/clickhouse-tools/lib/python3.6/site-packages/click/core.py", line 1659, in invoke
                return _process_result(sub_ctx.command.invoke(sub_ctx))
              File "/opt/yandex/clickhouse-tools/lib/python3.6/site-packages/click/core.py", line 1395, in invoke
                return ctx.invoke(self.callback, **ctx.params)
              File "/opt/yandex/clickhouse-tools/lib/python3.6/site-packages/click/core.py", line 754, in invoke
                return __callback(*args, **kwargs)
              File "/opt/yandex/clickhouse-tools/lib/python3.6/site-packages/click/decorators.py", line 26, in new_func
                return f(get_current_context(), *args, **kwargs)
              File "/opt/yandex/clickhouse-tools/lib/python3.6/site-packages/ch_tools/chadmin/cli/wait_group.py", line 125, in wait_replication_sync_command
                settings={"receive_timeout": timeout},
              File "/opt/yandex/clickhouse-tools/lib/python3.6/site-packages/ch_tools/chadmin/internal/utils.py", line 36, in execute_query
                settings=settings,
              File "/opt/yandex/clickhouse-tools/lib/python3.6/site-packages/tenacity/__init__.py", line 289, in wrapped_f
                return self(f, *args, **kw)
              File "/opt/yandex/clickhouse-tools/lib/python3.6/site-packages/tenacity/__init__.py", line 379, in __call__
                do = self.iter(retry_state=retry_state)
              File "/opt/yandex/clickhouse-tools/lib/python3.6/site-packages/tenacity/__init__.py", line 314, in iter
                return fut.result()
              File "/usr/lib/python3.6/concurrent/futures/_base.py", line 425, in result
                return self.__get_result()
              File "/usr/lib/python3.6/concurrent/futures/_base.py", line 384, in __get_result
                raise self._exception
              File "/opt/yandex/clickhouse-tools/lib/python3.6/site-packages/tenacity/__init__.py", line 382, in __call__
                result = fn(*args, **kwargs)
              File "/opt/yandex/clickhouse-tools/lib/python3.6/site-packages/ch_tools/common/clickhouse/client/clickhouse_client.py", line 241, in query
                found_port,
              File "/opt/yandex/clickhouse-tools/lib/python3.6/site-packages/ch_tools/common/clickhouse/client/clickhouse_client.py", line 148, in _execute_http
                raise ClickhouseError(query, e.response) from None
            ch_tools.common.clickhouse.client.error.ClickhouseError: Code: 62. DB::Exception: Syntax error: failed at position 26 ('.'): .inner_id.0fb9b053-6828-464a-bc34-dd8dd1347a11
            . Expected identifier. (SYNTAX_ERROR) (version 23.3.19.32 (official build))

            Query: SYSTEM SYNC REPLICA logs..inner_id.0fb9b053-6828-464a-bc34-dd8dd1347a11

@MikhailBurdukov MikhailBurdukov merged commit b72174a into main Mar 24, 2024
16 checks passed
@MikhailBurdukov MikhailBurdukov deleted the alex-burmak branch March 24, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants