Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support overriding thresholds through config #122

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Support overriding thresholds through config #122

merged 1 commit into from
Apr 11, 2024

Conversation

Alex-Burmak
Copy link
Member

No description provided.

@Alex-Burmak
Copy link
Member Author

Relates to https://st.yandex-team.ru/MDB-28487

@@ -28,61 +28,53 @@ def wait_group():
"--replica-timeout",
"replica_timeout",
type=TimeSpanParamType(),
default="1h",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to config file.

Default values are still present in help messages:

# chadmin wait replication-sync -h
Usage: chadmin wait replication-sync [OPTIONS]

  Wait for ClickHouse server to sync replication with other replicas.

Options:
  --replica-timeout TIMESPAN      Timeout for SYNC REPLICA command.  [default: 1h]
  --total-timeout TIMESPAN        Max amount of time to wait.  [default: 3d]
  -s, --status INTEGER            Wait until replication-lag returned status is no worse than given, 0 = OK, 1 = WARN, 2
                                  = CRIT.  [default: 0]
  -p, --pause TIMESPAN            Pause between replication lag requests.  [default: 30s]
  -x, --exec-critical INTEGER     Critical threshold for one task execution.  [default: 3600]
  -c, --critical INTEGER          Critical threshold for lag with errors.  [default: 600]
  -w, --warning INTEGER           Warning threshold.  [default: 300]
  -M, --merges-critical FLOAT RANGE
                                  Critical threshold in percent of max_replicated_merges_in_queue.  [default: 90.0;
                                  0.0<=x<=100.0]
  -m, --merges-warning FLOAT RANGE
                                  Warning threshold in percent of max_replicated_merges_in_queue.  [default: 50.0;
                                  0.0<=x<=100.0]
  -h, --help                      Show this message and exit.  [default: False]

@Alex-Burmak Alex-Burmak changed the title Support overring thresholds through config Support overriding thresholds through config Apr 11, 2024
@aalexfvk aalexfvk merged commit cb32cfd into main Apr 11, 2024
16 checks passed
@aalexfvk aalexfvk deleted the alex-burmak branch April 11, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants