Shorten the error message in orphaned-objects monrun check #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikitaUnisikhin
force-pushed
the
orp-objects-handle-error-refactoring
branch
from
9fda477 to
b8f23b8
Compare
NikitaUnisikhin
force-pushed
the
orp-objects-handle-error-refactoring
branch
12 times, most recently
from
39702c4 to
dabd301
Compare
NikitaUnisikhin
force-pushed
the
orp-objects-handle-error-refactoring
branch
from
dabd301 to
4b1fd6c
Compare
aalexfvk
reviewed
Dec 5, 2024
| @@ -52,7 +56,7 @@ def orphaned_objects_command( | |||
| return Result(CRIT, str(e)) | |||
|
|
|||
| total_size = state.orphaned_objects_size | |||
| error_msg = state.error_msg | |||
| error_msg = _error_message_format(state.error_msg) | |||
There was a problem hiding this comment.
Consider putting this action there to make it more general
There was a problem hiding this comment.
thks, that's much better. done
NikitaUnisikhin
force-pushed
the
orp-objects-handle-error-refactoring
branch
from
2ff022e to
dd93ace
Compare
NikitaUnisikhin
force-pushed
the
orp-objects-handle-error-refactoring
branch
from
dd93ace to
6229422
Compare
NikitaUnisikhin
force-pushed
the
orp-objects-handle-error-refactoring
branch
from
a246ae4 to
af66fd8
Compare
aalexfvk
reviewed
Dec 6, 2024
| """ | ||
| Then we get response | ||
| """ | ||
| 2;Code: 27. DB::Exception: ... (CANNOT_PARSE_INPUT_ASSERTION_FAILED) (version 24.8.5.115 (official build)) ... |
There was a problem hiding this comment.
Let's use we get response matches for checking response without specific versions
There was a problem hiding this comment.
The purpose of this test is to show the final error message, we are parsing an error that already contains "(version 24.8.5.115 (official build))", that is, this result of this test does not depend on the version of clickhouse.
Maybe I didn’t understand why to change this test.
There was a problem hiding this comment.
Ok, I got confused with the Scenario: Check Geobase test. But it is already fixed
NikitaUnisikhin
force-pushed
the
orp-objects-handle-error-refactoring
branch
from
d928fd4 to
af66fd8
Compare
NikitaUnisikhin
changed the title
aalexfvk
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.