Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config file support #77

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Config file support #77

merged 1 commit into from
Nov 23, 2023

Conversation

Alex-Burmak
Copy link
Member

No description provided.

@Alex-Burmak Alex-Burmak requested review from myrrc, MedvedewEM and aalexfvk and removed request for myrrc November 20, 2023 15:52
Copy link
Contributor

@myrrc myrrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but maybe we should add a test loading a custom config and also one loading an invalid config file (rights issue, non-existent issue, bad contents)?

@myrrc myrrc self-assigned this Nov 20, 2023
aalexfvk
aalexfvk previously approved these changes Nov 21, 2023
@aalexfvk aalexfvk dismissed their stale review November 21, 2023 18:53

Wait for tests

@myrrc
Copy link
Contributor

myrrc commented Nov 23, 2023

Tests will be added in a separate PR

@myrrc myrrc self-requested a review November 23, 2023 11:36
@myrrc myrrc merged commit 20d212e into main Nov 23, 2023
18 checks passed
@myrrc myrrc deleted the MDB-26402 branch November 23, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants