Add --keep-going option to "partition attach" and "partition detach" commands #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalexfvk
reviewed
Nov 23, 2023
| ) | ||
| except Exception as e: | ||
| if keep_going: | ||
| print(repr(e)) |
There was a problem hiding this comment.
To not hide error from a user and output it to stdout.
Here's an example output:
# chadmin partition attach --all -k
ALTER TABLE `db1`.`events` ATTACH PARTITION ID '20230306'
ClickhouseError("Code: 499. DB::Exception: The specified key does not exist.: while reading key: cloud_storage/cluster1001/shard1/r0000000000000000000000000000000000000000000011110011101111111001-file-ojvazctfenasiyjtsvzzsjmmubpdmgft, from bucket: cloud-storage-cluster1001. (S3_ERROR) (version 23.8.6.16 (official build))\n\nQuery: ALTER TABLE `db1`.`events` ATTACH PARTITION ID '20230306'",)
ALTER TABLE `db1`.`events` ATTACH PARTITION ID '20230326'
We can add logging in addition to outputting error to stdout. And error reporting to stdout not as good as it can be. But for now I implemented --keep-going option in consistent way with other commands that support it.
aalexfvk
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.