Wait replication sync using SYNC REPLICA #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalexfvk
reviewed
Jan 31, 2024
|
LGTM, it would be great if someone else take a look |
aalexfvk
reviewed
Feb 1, 2024
Alex-Burmak
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what default timeout value for SYNC REPLICA should be.
Command throws on SYNC REPLICA timeout. I thought we can just retry sync until total_timeout is reached, but I think current implementation allows us to know that something is not as expected much earlier.
Replication lag check is not removed in case something really weird happens.
Also I just print() on timeout because throwing exceptions result in some ugly traceback and useless message being printed, maybe there is a better way to do it.