Lagging replicas should not affert WaitSlaveCount (#136)

Co-authored-by: Aleksandr Shevchuk <[email protected]>
yandex · Oct 3, 2024 · 4a012aa · 4a012aa
1 parent 63cd7e3
commit 4a012aa
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/internal/app/app.go b/internal/app/app.go
@@ -1028,7 +1028,9 @@ func (app *App) updateActiveNodes(clusterState, clusterStateDcs map[string]*Node
 	if masterState.SemiSyncState != nil && masterState.SemiSyncState.MasterEnabled {
 		oldWaitSlaveCount = masterState.SemiSyncState.WaitSlaveCount
 	}
-	waitSlaveCount := app.switchHelper.GetRequiredWaitSlaveCount(activeNodes)
+	// data lagging replicas should not affect WaitSlaveCount
+	notLaggingActive := filterOut(activeNodes, becomeDataLag)
+	waitSlaveCount := app.switchHelper.GetRequiredWaitSlaveCount(notLaggingActive)
 
 	app.logger.Infof("update active nodes: active nodes are: %v, wait_slave_count %d", activeNodes, waitSlaveCount)
 	if len(becomeActive) > 0 {