fix: split brain when replica applied the transaction earlier

yandex · Mar 12, 2024 · 52e4624 · 52e4624
1 parent e4dc375
commit 52e4624
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/internal/app/app.go b/internal/app/app.go
@@ -869,7 +869,7 @@ func (app *App) calcActiveNodes(clusterState, clusterStateDcs map[string]*NodeSt
 			continue
 		}
 		sgtids := gtids.ParseGtidSet(sstatus.ExecutedGtidSet)
-		if !(sstatus.ReplicationState == mysql.ReplicationRunning && isGTIDLessOrEqual(sgtids, mgtids)) {
+		if !(sstatus.ReplicationState == mysql.ReplicationRunning && isSplitBrained(sgtids, mgtids)) {
 			app.logger.Errorf("calc active nodes: %s is not replicating or splitbrained, deleting from active...", host)
 			continue
 		}

diff --git a/internal/app/util.go b/internal/app/util.go
@@ -233,6 +233,10 @@ func isGTIDLessOrEqual(slaveGtidSet, masterGtidSet gtids.GTIDSet) bool {
 	return masterGtidSet.Contain(slaveGtidSet) || masterGtidSet.Equal(slaveGtidSet)
 }
 
+func isSplitBrained(firstGtidSet, secondGtidSet gtids.GTIDSet) bool {
+	return firstGtidSet.Contain(secondGtidSet) || secondGtidSet.Contain(firstGtidSet) || firstGtidSet.Equal(secondGtidSet)
+}
+
 func validatePriority(priority *int64) error {
 	if priority == nil || *priority >= 0 {
 		return nil